add notebook number to list of exercises to check#371
Open
RuthMahallaMilano wants to merge 1 commit intoPythonFreeCourse:masterfrom
Open
add notebook number to list of exercises to check#371RuthMahallaMilano wants to merge 1 commit intoPythonFreeCourse:masterfrom
RuthMahallaMilano wants to merge 1 commit intoPythonFreeCourse:masterfrom
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
yammesicka
reviewed
Mar 3, 2024
Comment on lines
+25
to
+27
| {%- if exercise['notebook'] %} | ||
| <td>{{ exercise['notebook'] }}</td> | ||
| {%- endif %} |
Member
There was a problem hiding this comment.
Alignment:
Suggested change
| {%- if exercise['notebook'] %} | |
| <td>{{ exercise['notebook'] }}</td> | |
| {%- endif %} | |
| {%- if exercise['notebook'] %} | |
| <td>{{ exercise['notebook'] }}</td> | |
| {%- endif %} |
yammesicka
reviewed
Mar 3, 2024
| <tr> | ||
| <th scope="col">#</th> | ||
| <th scope="col">{{ _('Name') }}</th> | ||
| <th scope="col">{{ _('Notebook') }}</th> |
Member
There was a problem hiding this comment.
We should check if any of the exercises has notebook before showing this column
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.